New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Chinese translation for docs/zh/docs/tutorial/dependencies/classes-as-dependencies.md
#4971
🌐 Add Chinese translation for docs/zh/docs/tutorial/dependencies/classes-as-dependencies.md
#4971
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4971 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13946 13946
=========================================
Hits 13946 13946 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📝 Docs preview for commit 37e04df at: https://6295d912b2eeb81e2e62dd3f--fastapi.netlify.app |
docs/zh/docs/tutorial/dependencies/classes-as-dependencies.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed your changes and made some optimization. Can I push them ?
Sure |
But it seems I have no permission:
Am I something wrong ? Or how can I push changes to this PR? Or can I only comment some lines in per review. Because I reviewed and changed much lines. Thanks. @tiangolo @Zssaer |
Looks like you don't have permission to do that. See |
Only the upstream repository maintainers can direct change it. |
@Zssaer Yeah, starting a review and making a suggested change is a normal way, you can agree or reject them. |
Jedore,你目前还是否有意愿进行提交一些修改?如果你嫌一段一段Request changes麻烦的话,我的意思是 你可以将这个PR的Branch给Fork下来,然后再进行PR给这个Branch。 |
之前没有对你的branch推送的权限,所以我已经将我所有的修改建议在上面以review的形式提交了,需要你去按需选择接受或拒绝就可以了。目前我没有其他的修改建议了,所以也不用再提PR给你的branch了 😂 |
可是我并没有收到你的相关review的提交 |
@Zssaer 现在可以看到了吗?第一次 review, 打开review, 忘记提交review了 |
0 Co-authored-by: Jeodre <jedore_fight@189.cn>
All suggestions to one Co-authored-by: Jeodre <jedore_fight@189.cn>
📝 Docs preview for commit a77ebd0 at: https://63600c790ccda20c0446c3b3--fastapi.netlify.app |
Translates docs/zh/docs/tutorial/dependencies/classes-as-dependencies.md and add deploy menu in Chinese.
related: #1228